Skip to content

DOC: Fixes additional flake8 issues in whatsnew v0.14.0 #24240 #24342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2018
Merged

DOC: Fixes additional flake8 issues in whatsnew v0.14.0 #24240 #24342

merged 1 commit into from
Dec 18, 2018

Conversation

Seuss27
Copy link
Contributor

@Seuss27 Seuss27 commented Dec 18, 2018 •
edited
Loading

Related to #24240

Fixed an indentation error that revealed more flake8 issues.

@Seuss27
DOC: Fixes additional flake8 issues in whatsnew v0.14.0 pandas-dev#24240
7e3a4fe 


Fixed an indentation error that revealed more flake8 issues.
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #24342 into master will decrease coverage by 49.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24342       +/-   ##
===========================================
- Coverage   92.28%      43%   -49.28%     
===========================================
  Files         162      162               
  Lines       51835    51835               
===========================================
- Hits        47834    22290    -25544     
- Misses       4001    29545    +25544
Flag Coverage Δ
#multiple ?
#single 43% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-98.65%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34adac...7e3a4fe. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 18, 2018 •
edited
Loading

Codecov Report

Merging #24342 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24342      +/-   ##
==========================================
+ Coverage   92.28%   92.28%   +<.01%     
==========================================
  Files         162      162              
  Lines       51835    51835              
==========================================
+ Hits        47834    47835       +1     
+ Misses       4001     4000       -1
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 43% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 87.58% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34adac...7e3a4fe. Read the comment docs.

datapythonista
datapythonista reviewed Dec 18, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Seuss27 the template we provide in the description of the pull request, helps us know which issue are you addressing, and it closes it automatically when we merge the PR. Instead of deleting it, the idea is that you replace the #xxxxx by the issue number, and tick all the checkboxes that apply.

For this PR, we need the changes in setup.cfg that remove the file from the exclusion list, so it's validated.

@Seuss27
Copy link
Contributor Author

Seuss27 commented Dec 18, 2018

@datapythonista This file was already processed and removed from setup.cfg, I noticed the compilation errors when I was debugging another rst file. Understood regarding the template and the usage.

datapythonista
datapythonista approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I see, thanks for clarifying @Seuss27

Next time it makes it easier if you say that in the PR description, and you add the PR number this is a follow up of.

@jreback jreback added this to the 0.24.0 milestone Dec 18, 2018
@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

are we not checking? since 0.14. is removed?

@datapythonista
Copy link
Member

For what I understand, flake8-rst wasn't detecting the issue, but it was generating warnings in the sphinx build. We will start taking care of the warnings when we fix the flake8-rst issues, so eventually we'll check them.

@jreback jreback merged commit 2c8b207 into pandas-dev:master Dec 18, 2018
@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

thanks @Seuss27

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 20, 2018
@Seuss27 @TomAugspurger
DOC: Fixes additional flake8 issues in whatsnew v0.14.0 pandas-dev#24240
77c5e18 
 (pandas-dev#24342)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@Seuss27 @Pingviinituutti
DOC: Fixes additional flake8 issues in whatsnew v0.14.0 pandas-dev#24240
3434947 
 (pandas-dev#24342)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@Seuss27 @Pingviinituutti
DOC: Fixes additional flake8 issues in whatsnew v0.14.0 pandas-dev#24240
44dc263 
 (pandas-dev#24342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Clean Docs
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Seuss27 @jreback @datapythonista